adding GetOtherNotificationFlags cDAC API #117616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new cDAC API GetOtherNotificationFlags to read notification flags from the target process, updates the global constants to include DacNotificationFlags, and registers this global in the native descriptor.
- Implements
IXCLRDataProcess.GetOtherNotificationFlagswith exception handling and debug cross-checks. - Adds
DacNotificationFlagsto managed contract constants. - Registers
DacNotificationFlagsindatadescriptor.h.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs | Added new GetOtherNotificationFlags implementation |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Constants.cs | Added DacNotificationFlags constant |
| src/coreclr/debug/runtimeinfo/datadescriptor.h | Registered DacNotificationFlags with CDAC_GLOBAL_POINTER |
Comments suppressed due to low confidence (2)
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs:213
- The new
GetOtherNotificationFlagsAPI lacks unit tests. Consider adding tests to cover successful reads, exception paths, and the debug-mode comparison against the legacy implementation.
int IXCLRDataProcess.GetOtherNotificationFlags(uint* flags)
src/coreclr/debug/runtimeinfo/datadescriptor.h:971
- [nitpick] This line is missing the leading space for alignment with the surrounding
CDAC_GLOBAL_POINTERentries; adding it will keep the code formatting consistent.
CDAC_GLOBAL_POINTER(DacNotificationFlags, &::g_dacNotificationFlags)
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Open
3 tasks
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/SOSDacImpl.IXCLRDataProcess.cs
Show resolved
Hide resolved
This was referenced Jul 16, 2025
This was referenced Jul 18, 2025
…untime into GetOtherNotificationFlags
max-charlamb
approved these changes
Jul 22, 2025
3 tasks
|
/ba-g infrastructure timeouts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.